Skip to content

Add microphone cutoff option#15

Merged
7w1 merged 2 commits into
SableClient:livekitfrom
sandstorm244:livekit
Jul 15, 2026
Merged

Add microphone cutoff option#15
7w1 merged 2 commits into
SableClient:livekitfrom
sandstorm244:livekit

Conversation

@sandstorm244

@sandstorm244 sandstorm244 commented Jul 10, 2026

Copy link
Copy Markdown

Content

Adds a user-configurable microphone cutoff volume (noise gate): mic input quieter than a chosen dBFS threshold is muted before being published.

  • New gate stage in the existing RNNoise AudioWorklet (level-based, with hysteresis, ~300ms hold and open/close gain smoothing) — works with RNNoise enabled or disabled
  • New Audio settings section: enable checkbox + cutoff slider (−60…−10 dB, default −40 dB)
  • The slider doubles as a live input meter fed by the worklet's own level measurement — green while above the cutoff (transmitting), grey while below (muted) — so the meter and gate are calibrated identically
  • Threshold changes apply live via worklet messages; no track restart needed. Gate-only mode lifts the 48kHz sample-rate requirement (that's RNNoise-specific)

Motivation and context

Because noise supression just isnt enough, a cut-off helps quite alot.
Similar PR upstream got closed for some reason perhaps we can have this nice feature here?

Screenshots / GIFs

image

Tests

  • 16 new unit tests: gate DSP through the worklet test harness (mutes below cutoff, passes above, hold window, reopen timing, level reporting), processor config plumbing, Publisher attach/detach/live-update, settings UI
  • Manually against the local devenv backend: two participants, one muted + listening; tuned the cutoff with the live meter, confirmed speech cuts out above threshold, background noise (tapping on a can lol/keyboard) muted at −40 dB, word endings not clipped
  • Verified with RNNoise on and off, and that disabling the cutoff removes the processor entirely
  • lint:types, lint:oxlint, lint:knip, format:check, i18n:check, build:full, build:embedded all pass

For transparency sake, i have used AI in this PR.

Feel free to adjust or close if there is a better implementation.

@7w1

7w1 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Lgtm for the most part, only thing I noticed is in that screenshot there's a huge gap between the checkbox and the slider? Could you adjust that styling so it's more consistent (although I know some of the other settings aren't consistent, but i'd like to start trying to get them more uniform)

@sandstorm244

sandstorm244 commented Jul 13, 2026

Copy link
Copy Markdown
Author

Indeed, adjusted it a bit:

image

@sandstorm244

sandstorm244 commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Not super relevant to this specific PR but im sure these patches might be interesting, fixes a couple of issues.
https://github.com/sandstorm244/sable-patches

Aswell as a custom client with venmic implemented (mega ai slop warning, but i've tested it pretty rigorously and it seems stable enough)
https://github.com/sandstorm244/sable-shell

@7w1 7w1 merged commit e83c70d into SableClient:livekit Jul 15, 2026
4 checks passed
@7w1

7w1 commented Jul 15, 2026

Copy link
Copy Markdown
Member

Not super relevant to this specific PR but im sure these patches might be interesting, fixes a couple of issues. https://github.com/sandstorm244/sable-patches

Open some PRs for those! They do indeed seem pretty good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7w1 7w1 7w1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sandstorm244 @7w1